Fix Cecil metadata importer #11377
Merged
Fix Cecil metadata importer #11377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
kekekeks
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
XamlX PR kekekeks/XamlX#88
Cecil default metadata importer seem to have not that much sense adding IL references from the dependencies of different version instead of using local ones. So, we need to help it find the way,
In general, it seems like MetadataImporter must be redefined if developer has changed AssemblyResolver logic, as these must be synced.
See submodule changes for more details kekekeks/XamlX@e5254eb...c5d5d8b
What is the current behavior?
While building app in .NET 7 target with .NET 6 Avalonia (or .NET Core 2.1+ target with .NET Standard 2.0 Avalonia...).
Before Cecil+XAMLX:
After Cecil+XAMLX:
Duplicated references are from .NET 6.0 runtime (used in Avalonia assemblies APIs). But .NET 7.0 only is expected.
What is the updated/expected behavior with this PR?
Before Cecil+XAMLX: the same as it was.
After Cecil+XAMLX:
New IL references added, but all are of correct version used from target framework.
Fixed issues
Fixes #5456